AppVeyor testing #1947
Merged
AppVeyor testing #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eeee886 show the regressions found by the revdep check. |
| @@ -148,7 +148,7 @@ src_desc.src_sqlite <- function(x) { | |||
|
|
|||
| sqlite_version <- function() { | |||
| if (utils::packageVersion("RSQLite") > 1) { | |||
| RSQLite::rsqliteVersion()[[2]] | |||
| get("rsqliteVersion", getNamespace("RSQLite"), mode = "function")()[[2]] | |||
There was a problem hiding this comment.
I think it's fine to leave it as is.
- couldn't update README.md - install devtools and RSQLite from GitHub
|
Ready for review. |
|
LGTM |
|
Could you please visit https://ci.appveyor.com to enable testing? |
|
Done! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prepare for release.
Also remove NOTE that occurs with RSQLite 1.0.0 (current CRAN version), check now succeeds with both CRAN and bleeding-edge RSQLite.
Closes #1949 (=includes it).
Please visit https://ci.appveyor.com to enable testing.
Passes win-builder tests, too.