Skip to content

Commit

Permalink
Merge pull request #6967 from tidyverse/rc/1.1.4
Browse files Browse the repository at this point in the history
RC 1.1.4
  • Loading branch information
DavisVaughan committed Nov 17, 2023
2 parents 0f089c4 + 74de244 commit bb75242
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: dplyr
Title: A Grammar of Data Manipulation
Version: 1.1.3.9000
Version: 1.1.4
Authors@R: c(
person("Hadley", "Wickham", , "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0003-4757-117X")),
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# dplyr (development version)
# dplyr 1.1.4

* `join_by()` now allows its helper functions to be namespaced with `dplyr::`,
like `join_by(dplyr::between(x, lower, upper))` (#6838).
Expand Down
12 changes: 6 additions & 6 deletions tests/testthat/test-deprec-combine.R
Original file line number Diff line number Diff line change
Expand Up @@ -180,26 +180,26 @@ test_that("combine works with NA and complex (#2203)", {
withr::local_options(lifecycle_verbosity = "quiet")

# NA first
expected_result <- c(NA, 1 + 2i)
works1 <- combine(list(NA, 1 + 2i))
expected_result <- c(NA_complex_, 1 + 2i)
works1 <- combine(list(NA_complex_, 1 + 2i))
expect_equal(works1, expected_result)

# NA length == 1
expected_result <- c(1 + 1i, 2 + 1i, NA, 4 + 1i)
expected_result <- c(1 + 1i, 2 + 1i, NA_complex_, 4 + 1i)

expect_equal(combine(as.list(expected_result)), expected_result)

works2 <- combine(list(1 + 1i, 2 + 1i, NA, 4 + 1i))
works2 <- combine(list(1 + 1i, 2 + 1i, NA_complex_, 4 + 1i))
expect_equal(works2, expected_result)

# NA length > 1
expected_result <- c(1 + 1i, 2 + 1i, NA, NA, 4 + 1i)
expected_result <- c(1 + 1i, 2 + 1i, NA_complex_, NA_complex_, 4 + 1i)
expect_equal(
combine(split(expected_result, c(1, 2, 3, 3, 4))),
expected_result
)

works3 <- combine(list(1 + 1i, 2 + 1i, c(NA, NA), 4 + 1i))
works3 <- combine(list(1 + 1i, 2 + 1i, c(NA_complex_, NA_complex_), 4 + 1i))
expect_equal(works3, expected_result)
})

Expand Down

0 comments on commit bb75242

Please sign in to comment.