Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stylelint violations #1150

Merged

Conversation

stevepolitodesign
Copy link
Contributor

In #1148 we introduce stylelint. However, the empty styles introduced
in #1145 are empty file violations. By adding comments, we avoid that
error.

Note that we need to add these comments because there's no way to
automatically fix those violations with something like prettier.

@stevepolitodesign stevepolitodesign changed the base branch from main to suspenders-3-0-0 December 11, 2023 16:56
In #1148 we introduce `stylelint`. However, the empty styles introduced
in #1145 are empty file violations. By adding comments, we avoid that
error.

Note that we need to add these comments because there's no way to
automatically fix those violations with something like `prettier`.
@stevepolitodesign stevepolitodesign force-pushed the suspenders-3-0-0-stylelint-violation-fix branch from 8353888 to 633b919 Compare December 11, 2023 16:57
@stevepolitodesign stevepolitodesign merged commit 81e0e68 into suspenders-3-0-0 Dec 11, 2023
2 checks passed
@stevepolitodesign stevepolitodesign deleted the suspenders-3-0-0-stylelint-violation-fix branch December 11, 2023 17:00
stevepolitodesign added a commit that referenced this pull request May 10, 2024
In #1148 we introduce `stylelint`. However, the empty style sheets introduced in
#1145 are empty file violations. By adding comments, we avoid that error.

Note that we need to add these comments because there's no way to
automatically fix those violations with something like `prettier`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant