Insert gems alphabetically

[toobulkeh]

Here is the Gemfile that is created when suspenders generates an app now:

source "https://rubygems.org"

git_source(:github) do |repo_name|
  repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/")
  "https://github.com/#{repo_name}.git"
end

ruby "2.5.0"

gem "autoprefixer-rails"
gem "flutie"
gem "honeybadger"
gem "jquery-rails"
gem "pg", "~> 0.18"
gem "puma"
gem "rack-canonical-host"
gem "rails", "~> 5.1.4"
gem "recipient_interceptor"
gem "sass-rails", "~> 5.0"
gem "skylight"
gem "sprockets", ">= 3.0.0"
gem "suspenders"
gem "title"
gem "uglifier"


group :development do
  gem "listen"
  gem "rack-mini-profiler", require: false
  gem "spring"
  gem "web-console"
end

group :development, :test do
  gem "awesome_print"
  gem "bundler-audit", ">= 0.5.0", require: false
  gem "dotenv-rails"
  gem "pry-byebug"
  gem "pry-rails"
end

group :test do
  gem "formulaic"
  gem "launchy"
  gem "simplecov", require: false
  gem "timecop"
  gem "webmock"
end

group :production do
  gem "rack-timeout"
end

gem 'high_voltage'
gem 'bourbon', '~> 5.0'
gem 'neat', '~> 2.1'
gem 'refills', group: [:development, :test]
gem 'spring-commands-rspec', group: :development
gem 'rspec-rails', '~> 3.6', group: [:development, :test]
gem 'shoulda-matchers', group: :test
gem 'capybara-webkit', group: :test
gem 'simple_form'
gem 'bullet', group: [:development, :test]
gem 'factory_bot_rails', group: [:development, :test]

Not sure what happened -- but it use to be cleaner, like:

source "https://rubygems.org"

git_source(:github) do |repo_name|
  repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/")
  "https://github.com/#{repo_name}.git"
end

ruby "2.5.0"

gem "autoprefixer-rails"
gem "bourbon", "~> 5.0"
gem "bullet"
gem "factory_bot_rails"
gem "flutie"
gem "high_voltage"
gem "honeybadger"
gem "jquery-rails"
gem "neat", "~> 2.1"
gem "pg", "~> 0.18"
gem "puma"
gem "rack-canonical-host"
gem "rails", "~> 5.1.4"
gem "recipient_interceptor"
gem "sass-rails", "~> 5.0"
gem "simple_form"
gem "skylight"
gem "sprockets", ">= 3.0.0"
gem "suspenders"
gem "title"
gem "uglifier"

group :development do
  gem "listen"
  gem "rack-mini-profiler", require: false
  gem "spring"
  gem "spring-commands-rspec"
  gem "web-console"
end

group :development, :test do
  gem "awesome_print"
  gem "bundler-audit", ">= 0.5.0", require: false
  gem "dotenv-rails"
  gem "pry-byebug"
  gem "pry-rails"
  gem "rspec-rails", "~> 3.6"
  gem "refills"
end

group :test do
  gem "capybara-webkit"
  gem "formulaic"
  gem "launchy"
  gem "shoulda-matchers"
  gem "simplecov", require: false
  gem "timecop"
  gem "webmock"
end

group :production do
  gem "rack-timeout"
end

Differences:

1. Alphabetize
2. Using groups
3. Double-quotes

[mike-burns]

It's true, this came from a switch to using Rails gem helper.

I was not thrilled with the result but assumed no one else cared. But apparently people do!

I think the thing to do is to write a custom gem helper that gets us back to where we were: it would insert the gem alphabetically, in the appropriate group, using double quotes.

I don't have the bandwidth to do that over the new few months, unfortunately, but it seems like a surprisingly fun method to write.

[stevepolitodesign]

Now that #1135 has been merged, the suspenders:cleanup:gemfile task introduced in #1181 is available, and runs when suspending new applications. However, it does not alphabetize the gems.

Do we still feel it's important to alphabetize the gems? Or, is the task introduced in #1181 sufficient enough?

[mike-burns]

I think Standard does that for us.