Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to add 'brew bundle' clarification #217

Closed
wants to merge 3 commits into from
Closed

Update README.md to add 'brew bundle' clarification #217

wants to merge 3 commits into from

Conversation

wbnns
Copy link
Contributor

@wbnns wbnns commented Jan 23, 2014

Resolves #216 and adds note about ensuring user is in Clone/Fork root before 'brew bundle' is run.

@@ -18,11 +18,11 @@ Clone onto your laptop:
(Or, [fork and keep your fork
updated](http://robots.thoughtbot.com/keeping-a-github-fork-updated)).

Install [rcm](https://github.com/thoughtbot/rcm):
In the Root Directory of Clone/Fork and Install [rcm](https://github.com/thoughtbot/rcm):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read this a few times before understanding what it meant. Maybe I just understand code better, but I think something like this would be clearer:

Install rcm:

cd dotfiles
brew bundle

@wbnns
Copy link
Contributor Author

wbnns commented Jan 23, 2014

@jferris thanks for the feedback

@@ -20,6 +20,7 @@ updated](http://robots.thoughtbot.com/keeping-a-github-fork-updated)).

Install [rcm](https://github.com/thoughtbot/rcm):

cd dotfiles

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: you can use brew bundle ~/dotfiles/Brewfile instead of cd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better approach, since the next section would require the user to go up a directory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know I needed to go back up a directory to run 'rcup -d dotfiles -x README.md -x LICENSE' - looks like I wasn't installing properly after 'brew bundle' - how do you all think I could make that more explicit in a way that still make sense?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to avoid any cding around if it's possible. Less actions => simpler installation process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vdmgolub and @gylaz

@mike-burns
Copy link
Contributor

rcm assumes ~/.dotfiles by default.

@wbnns
Copy link
Contributor Author

wbnns commented Feb 10, 2014

@mike-burns Hi Mike! So it doesn't matter anymore if a user isn't in ~/ when they run brew bundle? I had a failed installation because I wasn't running brew in the root folder a couple of weeks ago.

@mike-burns
Copy link
Contributor

I don't know much (anything?) about Homebrew, but I did want to point out that our rcm project assumes dotfiles are cloned into ~/.dotfiles. It might be good to unify this between our projects.

@gylaz
Copy link
Contributor

gylaz commented Mar 7, 2014

Thanks @GWB3. Merged as bf82a62

@gylaz gylaz closed this Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Note to 'cd' to Clone/Fork root before 'brew bundle'
5 participants