Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README does not reflect latest changes to railsrc #746

Closed
stevepolitodesign opened this issue May 2, 2024 · 0 comments · Fixed by #747
Closed

README does not reflect latest changes to railsrc #746

stevepolitodesign opened this issue May 2, 2024 · 0 comments · Fixed by #747

Comments

@stevepolitodesign
Copy link
Contributor

The introduction of #744 failed to update the corresponding section in README.

dotfiles/README.md

Lines 219 to 221 in 681553f

- Adds [railsrc][] with `--database=postgresql`. If you need to use another
database, you can override this value like so: `rails new my_app --database=mysql` or
`rails new my_app --no_rc`

@stevepolitodesign stevepolitodesign mentioned this issue May 10, 2024
Merged
stevepolitodesign added a commit that referenced this issue May 10, 2024
@stevepolitodesign
railsrc: Add application template
27e8d80 
Now that [Suspenders 3.0.0][] has [merged][], we can improve the
developer experience by placing all option into our `railsrc` file.

Once this commit it merged, we can link to our dotfiles from the
Suspenders README.

Also closes #746

[Suspenders 3.0.0]: https://github.com/thoughtbot/suspenders
[merged]: thoughtbot/suspenders#1135
stevepolitodesign added a commit that referenced this issue May 10, 2024
@stevepolitodesign
railsrc: Add application template
80594f4 
Now that [Suspenders 3.0.0][] has [merged][], we can improve the
developer experience by placing all option into our `railsrc` file.

Once this commit it merged, we can link to our dotfiles from the
Suspenders README.

Also closes #746

[Suspenders 3.0.0]: https://github.com/thoughtbot/suspenders
[merged]: thoughtbot/suspenders#1135
stevepolitodesign added a commit that referenced this issue May 10, 2024
@stevepolitodesign
railsrc: Add application template (#747)
1cd64fa 
Now that [Suspenders 3.0.0][] has [merged][], we can improve the
developer experience by placing all options into our `railsrc` file.

Once this commit it merged, we can link to our dotfiles from the
Suspenders README.

Also closes #746

[Suspenders 3.0.0]: https://github.com/thoughtbot/suspenders
[merged]: thoughtbot/suspenders#1135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

railsrc: Add application template thoughtbot/dotfiles
1 participant
@stevepolitodesign