Do not override :Ag command #682
Comments
danielnolan
added a commit
that referenced
this issue
Sep 20, 2022
* The Ag command from fzf.vim that loads the fzf shell does seem more useful than than the command being defined here. The one downside I see though is that `:Ag some_search` will open the fzf shell rather than populating the vim quickfix window, however you can just select all files in the fzf shell with alt-a and click enter to add all the files in the fzf shell to a quickfix window. * Remove custom :Ag command vim in favor of :Ag command defined in fzf.vim * Closes #682
danielnolan
added a commit
that referenced
this issue
Sep 23, 2022
* The Ag command from fzf.vim that loads the fzf shell does seem more useful than than the command being defined here. The one downside I see though is that `:Ag some_search` will open the fzf shell rather than populating the vim quickfix window, however you can just select all files in the fzf shell with alt-a and click enter to add all the files in the fzf shell to a quickfix window. * Remove custom :Ag command vim in favor of :Ag command defined in fzf.vim * Closes #682
kmorisoto
pushed a commit
to kmorisoto/dotfiles
that referenced
this issue
Dec 18, 2022
* The Ag command from fzf.vim that loads the fzf shell does seem more useful than than the command being defined here. The one downside I see though is that `:Ag some_search` will open the fzf shell rather than populating the vim quickfix window, however you can just select all files in the fzf shell with alt-a and click enter to add all the files in the fzf shell to a quickfix window. * Remove custom :Ag command vim in favor of :Ag command defined in fzf.vim * Closes thoughtbot#682
adamjparrott
pushed a commit
to adamjparrott/dotfiles
that referenced
this issue
Jul 2, 2023
* The Ag command from fzf.vim that loads the fzf shell does seem more useful than than the command being defined here. The one downside I see though is that `:Ag some_search` will open the fzf shell rather than populating the vim quickfix window, however you can just select all files in the fzf shell with alt-a and click enter to add all the files in the fzf shell to a quickfix window. * Remove custom :Ag command vim in favor of :Ag command defined in fzf.vim * Closes thoughtbot#682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current
vimrcfile is defining a custom:Agcommand to useag:dotfiles/vimrc
Lines 97 to 101 in 2a59c18
This command raises an error when I try to run it without arguments. Also, it doesn't open a new interactive window with the
Ag>shell.I believe that defining this command is not necessary nor optimal anymore.
The
fzf.vimplugin defines its own:Agcommand. This command can't be run at the moment (because it's overridden by ourvimrc).In my opinion, the lines that define the custom
:Agcommand invimrcshould be removed and we should allow the:Agcommand fromfzf.vimto work as expected.The text was updated successfully, but these errors were encountered: