Fix MutatorMulti for > 2 mutators and make code more idiomatic #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation only gave an uniform distribution with <= 2 mutators; else, in a series of N mutators, only the first one had probability 1/N, while the other ones had decreasing ones (e.g. the second had 1/N - 1/N^2) except the very last, which was too likely to be invoked. Also changed the receiver of Mutate() to a pointer receiver, which is more correct (the value receiver only happened to work because the fields of GAMutatorMulti are all slices, i.e. references.
thoj
added a commit
that referenced
this pull request
Dec 28, 2015
Fix MutatorMulti for > 2 mutators and make code more idiomatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have fixed an issue with the GAMutatorMulti. The current code does not select the mutators with equal probability except in the case of 2 mutators (and the trivial case of 1 mutator).
I also cleaned up the code a bit, made it more idiomatic and added a test (which I used to test my fix).
Thanks!