Restore to CodeMirror default on unload

thisdotrob · Dec 27, 2020 · 4552be8 · 4552be8
1 parent 3f03f83
commit 4552be8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/main.ts b/main.ts
@@ -1,8 +1,6 @@
 import { Plugin } from "obsidian";
 
 export default class RelativeLineNumbers extends Plugin {
-  initialLineNumberFormatter: (line: number) => string;
-
   onload() {
     // @ts-ignore
     const showLineNumber: Boolean = this.app.vault.getConfig("showLineNumber");
@@ -12,16 +10,18 @@ export default class RelativeLineNumbers extends Plugin {
 
     this.registerCodeMirror((cm) => {
       cm.on("cursorActivity", this.relativeLineNumbers);
-      // I haven't found a way to get the default value for an option,
-      // so we'll store the value at the time we loaded
-      this.initialLineNumberFormatter = cm.getOption("lineNumberFormatter");
     });
   }
 
   onunload() {
     this.app.workspace.iterateCodeMirrors((cm) => {
       cm.off("cursorActivity", this.relativeLineNumbers);
-      cm.setOption("lineNumberFormatter", this.initialLineNumberFormatter);
+      // @ts-ignore
+      cm.setOption(
+        "lineNumberFormatter",
+        // @ts-ignore
+        CodeMirror.defaults["lineNumberFormatter"]
+      );
     });
   }
 

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-relative-line-numbers",
 	"name": "Relative Line Numbers",
-	"version": "1.0.2",
+	"version": "1.0.3",
 	"minAppVersion": "0.10.0",
 	"description": "Enables relative line numbers in editor mode",
 	"author": "Nadav Spiegelman",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "obsidian-relative-line-numbers",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Enables relative line numbers in editor mode",
   "main": "main.js",
   "scripts": {

diff --git a/versions.json b/versions.json
@@ -1,4 +1,5 @@
 {
+	"1.0.3": "0.10.0",
 	"1.0.2": "0.10.0",
 	"1.0.1": "0.10.0"
 }