[shader-ast] allow unwrapped type strings in `defn` arg lists #98

postspectacular · 2019-07-08T00:34:47Z

Currently, each defn arg is an array of [type, name?, opts?]:

defn("void", "foo", [["vec2"], ["float"]], ...)

If no arg names/opts are used (as in above case), we should also allow just plain type strings, like so:

defn("void", "foo", ["vec2", "float"], ...)

The text was updated successfully, but these errors were encountered:

* develop: fix(shader-ast): builtin `not` (bvec) used wrong internal fn name build: update all pkg doc scripts to ignore TS compiler errors Publish fix(examples): minor fix webgl-msdf demo fix(vectors): reflect output handling fix(matrices): mixQ result handling refactor(examples): update shader fn arg lists (#98) minor(webgl-msdf): update shader fn args refactor(shader-ast-stdlib): update function arg lists (#98) fix(shader-ast): fix #98, update defn() arg lists, add/update docs fix(shader-ast-stdlib): update incomplete cartesian3, refactor cartesian2 Publish fix(resolve-map): fix #97, update to consider trailing comma & whitespace

postspectacular closed this as completed in bcfbcfd Jul 8, 2019

postspectacular added a commit that referenced this issue Jul 8, 2019

refactor(shader-ast-stdlib): update function arg lists (#98)

7d5fdce

postspectacular added a commit that referenced this issue Jul 8, 2019

refactor(examples): update shader fn arg lists (#98)

78a9185

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[shader-ast] allow unwrapped type strings in `defn` arg lists #98

[shader-ast] allow unwrapped type strings in `defn` arg lists #98

postspectacular commented Jul 8, 2019

[shader-ast] allow unwrapped type strings in defn arg lists #98

[shader-ast] allow unwrapped type strings in defn arg lists #98

Comments

postspectacular commented Jul 8, 2019

[shader-ast] allow unwrapped type strings in `defn` arg lists #98

[shader-ast] allow unwrapped type strings in `defn` arg lists #98