Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TAP for keyid flexibility #112

Merged
merged 10 commits into from
Apr 21, 2020
Merged

Add TAP for keyid flexibility #112

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
31095de
Add tap for keyid flexibility
mnm678 Mar 19, 2020
19dcf52
update abstract and address feedback
mnm678 Mar 20, 2020
78b5251
minor clarifications and variable name changes
mnm678 Mar 23, 2020
008049e
require that clients check for unique keys and add example for the sa…
mnm678 Mar 26, 2020
161bf47
update headers
mnm678 Mar 30, 2020
c764e9c
add description of client uniqueness check to the description of the …
mnm678 Mar 31, 2020
aa95c2c
Apply suggestions from code review
mnm678 Apr 3, 2020
36cf4dd
Remove non-permanent PEP 458 link and add definition of delegating roles
mnm678 Apr 9, 2020
a232e20
De-duplicate keys using a standardized format
mnm678 Apr 14, 2020
4a43010
Apply suggestions from code review
mnm678 Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove non-permanent PEP 458 link and add definition of delegating roles
  • Loading branch information
@mnm678
mnm678 committed Apr 9, 2020
commit 36cf4dd67e52422c9533377ebfc4779e5d64f3bc
10 changes: 5 additions & 5 deletions candidate-keyid-tap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
* TAP: TBD
* Title: Improving keyid flexibility
* Version: 1.0.0
* Last-Modified: 30-03-2020
* Last-Modified: 09-04-2020
* Author: Marina Moore
* Status: Draft
* Content-Type: markdown
Expand Down Expand Up @@ -49,8 +49,8 @@ The specification sets the following requirements for keyid calculation:
Mandating that keyids be calculated using SHA2-256 has created a number of issues
for some implementations, such as:
* Lack of consistency in implementations that use other hash algorithms for
calculating file hashes and would prefer not to introduce SHA2-256 for this one
instance. For example, the PEP 458 implementation (https://python.zulipchat.com/#narrow/stream/223926-pep458-implementation)
calculating file hashes and would prefer not to introduce SHA2-256 for this
one instance. For example, the PEP 458 implementation
will use the BLAKE2 hashing algorithm throughout the implementation.
* Incompatibility with some smart cards and PGP implementations that have their
own way of calculating keyids.
Expand Down Expand Up @@ -106,8 +106,8 @@ specification wording should be updated to allow the metadata owner to calculate
keyids using any method that produces a unique identifier within the metadata
file. This means replacing requirements 1 and 2 above with a description of
required keyid properties, ie “The KEYID is an identifier for the key that is
determined by the metadata owner and MUST be unique within the root or
delegating targets metadata file.” Once this keyid is determined by the metadata
determined by the metadata owner and MUST be unique within the delegating metadata file (either root or
delegating targets metadata).” Once this keyid is determined by the metadata
owner using their chosen method, it will be listed in the delegating metadata
file and in all signatures that use the corresponding key. When parsing metadata
signatures, the client would use the keyid(s) listed in the signature header to
Expand Down