Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use:action to SidebarItem #1054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shinokada
Copy link
Collaborator

Closes #933

πŸ“‘ Description

  • add use:action to the a tag
  • add example to docs/components/sidebar

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Sep 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Sep 9, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 9, 2023 7:05pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 9, 2023 7:05pm

@shinokada
Copy link
Collaborator Author

@jjagielka Can you have a look at this PR? What do you think?

@jjagielka
Copy link
Contributor

  1. Your implementation of the action misses the parameters. Please take a look at Frame component where actions are implemented by 2 props: action and options.
  2. Why Sidebar's a element is so special that requires the action? Why not to add it on all components?

@shinokada
Copy link
Collaborator Author

@jjagielka Thanks.
That's what I asked about your Q2. #933 (comment)

@kripi-png
Copy link

Any progress on this? I would like to have use:action available for other elements as well.
For example, on Input elements, it would allow dynamic types via a helper component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SidebarItem not usable with use:action
3 participants