Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wording: dust off 1Lab.Path #379

Merged
merged 8 commits into from
Jun 6, 2024
Merged

wording: dust off 1Lab.Path #379

merged 8 commits into from
Jun 6, 2024

Conversation

plt-amy
Copy link
Member

@plt-amy plt-amy commented May 29, 2024

Pretty major cleanup of the wording in 1Lab.Path, incorporating some feedback I got recently (and trying to fit the prose to the code and vice-versa).

@Lavenza
Copy link
Member

Lavenza commented May 29, 2024

Pull request preview

@plt-amy plt-amy force-pushed the aliao/path-wording branch 2 times, most recently from 9990892 to 5fe1533 Compare May 29, 2024 21:59
Copy link
Collaborator

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, only a quarter of the way through, but didn't feel worth holding on to this until the end.

src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, really taking my time on going through this. This definitely feels like an improvement though, I definitely feel like I'm grokking it much better.

src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing on the remaining half, but otherwise 👍

src/1Lab/Path.lagda.md Show resolved Hide resolved
@plt-amy plt-amy requested review from SquidDev and ncfavier June 6, 2024 04:25
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Show resolved Hide resolved
src/1Lab/Path.lagda.md Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Outdated Show resolved Hide resolved
src/1Lab/Path.lagda.md Show resolved Hide resolved
@plt-amy plt-amy requested a review from SquidDev June 6, 2024 19:42
Copy link
Collaborator

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@plt-amy plt-amy merged commit e374668 into main Jun 6, 2024
5 checks passed
@plt-amy plt-amy deleted the aliao/path-wording branch June 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants