store: fix series stats race #6596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niaurys
approved these changes
Aug 9, 2023
krisleipus
approved these changes
Aug 9, 2023
GiedriusS
force-pushed
the
fix_race_sstats
branch
from
0c666b5
to
b753072
Compare
The same aggregator is shared between queries which doesn't make sense as each aggregator should only aggregate Select stats available to it. Fixes a race and query metrics. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
fix_race_sstats
branch
from
b753072
to
5ade2c8
Compare
Titasp
approved these changes
Aug 9, 2023
GiedriusS
added a commit
to vinted/thanos
that referenced
this pull request
Aug 10, 2023
The same aggregator is shared between queries which doesn't make sense as each aggregator should only aggregate Select stats available to it. Fixes a race and query metrics. Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same aggregator is shared between queries which doesn't make sense
as each aggregator should only aggregate Select stats available to it.
Fixes a race and query metrics.