Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin: Remove dependency on the rule dashboard from compact dashboard #4029

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

goober
Copy link
Contributor

@goober goober commented Apr 7, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

This change will remove the dependency between the rule dashboard and the compact dashboard mixins to be able to only generate the compact dashboard without defining the rule dashboard.

Verification

The compact dashboard has been generated and imported to Grafana with and without the included change. No visible differences found.

@goober goober force-pushed the feature/fix-compact-mixin branch from fd2eeeb to 2687c10 Compare April 7, 2021 10:04
@goober goober force-pushed the feature/fix-compact-mixin branch from 2687c10 to 95fbbd8 Compare April 7, 2021 10:05
Copy link
Member

@wiardvanrij wiardvanrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👍

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏽

Thanks @wiardvanrij for review (:

@bwplotka bwplotka merged commit e7fadaf into thanos-io:main Apr 8, 2021
@goober goober deleted the feature/fix-compact-mixin branch June 17, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants