Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix tracing for alerts #1978

Merged
merged 1 commit into from
Jan 10, 2020
Merged

*: fix tracing for alerts #1978

merged 1 commit into from
Jan 10, 2020

Conversation

simonpasquier
Copy link
Contributor

Running Thanos Ruler on master generates warnings in the logs because the tracer isn't passed down to Sender.Send():

level=warn ts=2020-01-10T11:24:49.434277378Z caller=http.go:57 msg="Tracer not found in context."
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Pass the tracer in the context and generate spans when calling the Alertmanager API endpoint.

Verification

No more warning in the logs.
image

@simonpasquier
*: fix tracing for alerts
cf7d4f2 
Signed-off-by: Simon Pasquier <[email protected]>
bwplotka
bwplotka approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@bwplotka bwplotka merged commit 9c968a8 into thanos-io:master Jan 10, 2020
@simonpasquier simonpasquier deleted the fix-alert-tracing branch January 10, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonpasquier @bwplotka