query: Check duplicate external labels for all stores include existed store #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we change the external labels after store has already joined into storesets that will makes the external labels duplicated Check duplicate external labels before checking whether the store is exist or not
|
Does this PR could be merged? @bwplotka @GiedriusS |
bwplotka
approved these changes
May 21, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we change the external labels after store has already joined into storesets that will makes the external labels duplicated.
Changes
Check duplicate external labels before checking whether the store is exist or not.
Verification
Run unit test which has passed.
/assign @bwplotka
/cc @GiedriusS