Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/bucket: make getFor() work with interleaved resolutions #1146

Merged
merged 25 commits into from
May 27, 2019
Merged

store/bucket: make getFor() work with interleaved resolutions #1146

merged 25 commits into from
May 27, 2019

Commits on May 15, 2019

  1. store/bucket_test: add interleaved resolutions test for getFor()

    Giedrius Statkevičius committed May 15, 2019
    Configuration menu
    Copy the full SHA
    9c94918 View commit details
    Browse the repository at this point in the history

  2. store/bucket: include blocks in the middle as well

    Giedrius Statkevičius committed May 15, 2019
    Configuration menu
    Copy the full SHA
    cd3363c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. store/bucket: add test cases with duplicated time ranges

    Giedrius Statkevičius committed May 16, 2019
    Configuration menu
    Copy the full SHA
    00b2c7c View commit details
    Browse the repository at this point in the history

  2. query/querier: send proper maxSourceResolution 

    Without this, we get max resolutions like 1, 2, 3 which do not mean
anything to getFor(). With this, we get proper data from Thanos Store.
    Giedrius Statkevičius committed May 16, 2019
    Configuration menu
    Copy the full SHA
    8f22504 View commit details
    Browse the repository at this point in the history

  3. README: add entry

    Giedrius Statkevičius committed May 16, 2019
    Configuration menu
    Copy the full SHA
    e2c46bf View commit details
    Browse the repository at this point in the history

  4. query/querier_test: add queryableCreator test 

    Makes a querier via queryableCreator and checks if the
maxSourceResolution was passed properly.
    Giedrius Statkevičius committed May 16, 2019
    Configuration menu
    Copy the full SHA
    342aede View commit details
    Browse the repository at this point in the history

  5. store/bucket: do the iteration without sorting

    Giedrius Statkevičius committed May 16, 2019
    Configuration menu
    Copy the full SHA
    4e73b2f View commit details
    Browse the repository at this point in the history

  6. store/bucket: bsi->j in loop 

    Makes it clearer that it's just a temporary variable for the loop.
    Giedrius Statkevičius committed May 16, 2019
    Configuration menu
    Copy the full SHA
    fae1929 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Merge remote-tracking branch 'origin/master' into getFor

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    bf12553 View commit details
    Browse the repository at this point in the history

  2. store/bucket: fix according to review comments 

    * Convert parseDownsamplingParam() into parseDownsamplingParamMillis()
which properly returns int64 for use in the querier code
* Add parseDownsamplingMillis() tests
    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    de4b79a View commit details
    Browse the repository at this point in the history

  3. query/querier_test: fix test

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    c3abb09 View commit details
    Browse the repository at this point in the history

  4. *: clarify everywhere that max source resolution is in millis

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    f22cffa View commit details
    Browse the repository at this point in the history

  5. *: maxSourceResolutionMillis -> maxResolutionMillis

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    5e9d0e9 View commit details
    Browse the repository at this point in the history

  6. CHANGELOG: update

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    420ebe0 View commit details
    Browse the repository at this point in the history

  7. query/querier_test: fix

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    e8b3189 View commit details
    Browse the repository at this point in the history

  8. store/bucket: add gets all data in range property test

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    bacfd06 View commit details
    Browse the repository at this point in the history

  9. store/bucket_test: add production property test

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    93a764c View commit details
    Browse the repository at this point in the history

  10. store/bucket_test: fix

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    f4b0a66 View commit details
    Browse the repository at this point in the history

  11. store/bucket_test: add always gets property

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    dac133e View commit details
    Browse the repository at this point in the history

  12. query/querier_test: do not shrink

    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    dbe3727 View commit details
    Browse the repository at this point in the history

  13. store/bucket: revert change 

    This doesn't really matter as the tests show.
    Giedrius Statkevičius committed May 17, 2019
    Configuration menu
    Copy the full SHA
    6dac954 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. store/bucket_test: remove more confusion

    Giedrius Statkevičius committed May 18, 2019
    Configuration menu
    Copy the full SHA
    55aa32d View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. store/bucket: clean up tests 

    Only leave the property tests in place since they catch all of the
errors.
    Giedrius Statkevičius committed May 22, 2019
    Configuration menu
    Copy the full SHA
    3fe4217 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. Simplified goFor implementation. 

    Signed-off-by: Bartek Plotka <[email protected]>
    @bwplotka
    bwplotka committed May 27, 2019
    Configuration menu
    Copy the full SHA
    3bbc6cb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from improbable-eng/getFor 

    Simplified goFor implementation.
    Giedrius Statkevičius committed May 27, 2019
    Configuration menu
    Copy the full SHA
    3602678 View commit details
    Browse the repository at this point in the history