storage/prometheus: close querier at the end #484
+381
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
querier_close_at_the_end
branch
3 times, most recently
from
c0481a6
to
448b43c
Compare
GiedriusS
force-pushed
the
querier_close_at_the_end
branch
from
448b43c
to
dfc4015
Compare
MichaHoffmann
approved these changes
Sep 17, 2024
GiedriusS
force-pushed
the
querier_close_at_the_end
branch
9 times, most recently
from
06521a6
to
1c9cee0
Compare
We are trying to reuse memory and hitting a bug where the querier is closed too soon. Prometheus closes the querier at the end of Exec(). We should do that too. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
querier_close_at_the_end
branch
from
1c9cee0
to
0729ea7
Compare
storage/prometheus/scanners.go
Outdated
| func NewPrometheusScanners(queryable storage.Queryable, qOpts *query.Options, lplan logicalplan.Plan) (*Scanners, error) { | ||
| var min, max int64 | ||
| if lplan != nil { | ||
| min, max = findMinMaxTime(lplan, qOpts) |
There was a problem hiding this comment.
shouldnt this be set in logicalplan?
There was a problem hiding this comment.
Moved the logic to the logical plan.
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
querier_close_at_the_end
branch
from
d123622
to
38856a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to reuse memory and hitting a bug where the querier is closed too soon. Prometheus closes the querier at the end of Exec(). We should do that too.