#1588 Fixing up Android buffer problem and failing tests

[yaronyg]

SocketThreadBase - Turns out that the logic that got checked in could end up setting buffers to zero
because the Bluetooth socket get size calls could return 0. For now I decided to just remove the dynamic
size setting to simplify things. This should hopefully fix Android.

testThaliMobileNative - We have a condition where we could test something after we have called t.end but
this is necessary because our peer might be done with the test but the other might not. So now the test
will only cause a failure if it actually fails in which case we should fail.

testThaliMobileNativeWrapper - In addition to an identical issue to the one described above we also had tests
that were written before the skip functionality so I fixed that. Also some of the test names were so similar it
made doing searches hard so I added some text to make them different.

CoordinatedClient - Added the original result object to the error

makeIntoCloseAllServer - Linting

---

This change is 

[ThaliTester]

PR is added to the queue for testing as 1. task. (6721f4c)

[ThaliTester]

Test 96008345 (6721f4c) build started.

[ThaliTester]

Test (Fail) 96008345 build is completed (6721f4c)

See https://github.com/ThaliTester/TestResults/tree/960083456721f4c__1588_Fixing_up_Android_buffer_problem_and_failing_tests_yaronyg/ for the logs

[chapko]

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

test/www/jxcore/bv_tests/testThaliMobileNativeWrapper.js, line 448 at r1 (raw file):

test('can do HTTP requests between peers without coordinator',
  function() {
    return platform.isMobile;

It should be platform._isRealMobile everywhere. isMobile is always true on mocked Mobile.

---

Comments from Reviewable

[ThaliTester]

PR is added to the queue for testing as 1. task. (ac97228)

[ThaliTester]

Test 96008345 (ac97228) build started.

[ThaliTester]

Test (Success) 96008345 build is completed (ac97228)

See https://github.com/ThaliTester/TestResults/tree/96008345ac97228__1588_Fixing_up_Android_buffer_problem_and_failing_tests_yaronyg/ for the logs

[ThaliTester]

Test 96008345ac97228(ac97228) has failed

See https://github.com/ThaliTester/TestResults/tree/96008345ac97228__1588_Fixing_up_Android_buffer_problem_and_failing_tests_yaronyg/ for the fail logs

[vasilevskayaem]

@yaronyg I checked "coordinated seq test" and I can reproduce it only in NATIVE mode (seems that WIFI and BOTH works fine)

https://gist.github.com/vasilevskayaem/74fab06cbc29facace304800d03e39d4
https://gist.github.com/vasilevskayaem/f9e92847bcac2741a1293172e9bb5d71
https://gist.github.com/vasilevskayaem/818ceddd07e71a67ba3e04a378a5b5d9
https://gist.github.com/vasilevskayaem/0bc08c29d54d527efe9a1eca5cc7dea1

https://gist.github.com/vasilevskayaem/17eee59a838c994e5b5f89126bc51414
https://gist.github.com/vasilevskayaem/15d75cd2c75501f8adf157c7f31575fd
https://gist.github.com/vasilevskayaem/7266b3c0b3d7fec4eb91512c63303ad4
https://gist.github.com/vasilevskayaem/8c28a107382b2cc57a297c176bb64040

[ThaliTester]

PR is added to the queue for testing as 1. task. (c2441a7)

[ThaliTester]

Test 96008345 (c2441a7) build started.

[yaronyg]

Review status: 3 of 6 files reviewed at latest revision, 1 unresolved discussion.

---

test/www/jxcore/bv_tests/testThaliMobileNativeWrapper.js, line 448 at r1 (raw file):

Previously, chapko (Eugene Chapko) wrote…

It should be platform._isRealMobile everywhere. isMobile is always true on mocked Mobile.

An excellent point! Fixed

---

Comments from Reviewable

[ThaliTester]

Test (Success) 96008345 build is completed (c2441a7)

See https://github.com/ThaliTester/TestResults/tree/96008345c2441a7__1588_Fixing_up_Android_buffer_problem_and_failing_tests_yaronyg/ for the logs

[ThaliTester]

Test 96008345c2441a7(c2441a7) has failed

See https://github.com/ThaliTester/TestResults/tree/96008345c2441a7__1588_Fixing_up_Android_buffer_problem_and_failing_tests_yaronyg/ for the fail logs