Skip to content

Commit

Permalink
Downgrade "Bug: No entry found in extrainfo map" message.
Browse files Browse the repository at this point in the history
This is not actually a bug!  It can happen for a bunch of reasons,
which all boil down to "trying to add an extrainfo for which we no
longer have the corresponding routerinfo".

Fixes #16016; bugfix on 0.2.6.3-alpha.
  • Loading branch information
nmathewson committed Jun 30, 2020
1 parent 8697205 commit 39830b6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions changes/bug16016
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
o Minor bugfixes (logging):
- Downgrade a noisy log message that could occur naturally when
receiving an extrainfo document that we no longer want.
Fixes bug 16016; bugfix on 0.2.6.3-alpha.
6 changes: 5 additions & 1 deletion src/feature/nodelist/routerlist.c
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,11 @@ extrainfo_insert,(routerlist_t *rl, extrainfo_t *ei, int warn_if_incompatible))
* This just won't work. */;
static ratelim_t no_sd_ratelim = RATELIM_INIT(1800);
r = ROUTER_BAD_EI;
log_fn_ratelim(&no_sd_ratelim, severity, LD_BUG,
/* This is a DEBUG because it can happen naturally, if we tried
* to add an extrainfo for which we no longer have the
* corresponding routerinfo.
*/
log_fn_ratelim(&no_sd_ratelim, LOG_DEBUG, LD_DIR,
"No entry found in extrainfo map.");
goto done;
}
Expand Down

0 comments on commit 39830b6

Please sign in to comment.