-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed opposite refresh_alias behavior in modules/alias #372
fix: Fixed opposite refresh_alias behavior in modules/alias #372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, but please revert unnecessary changes in the example.
6add895
to
aa6a6aa
Compare
### [4.7.1](v4.7.0...v4.7.1) (2022-11-11) ### Bug Fixes * Fixed opposite refresh_alias behavior in modules/alias ([#372](#372)) ([f7b2a3a](f7b2a3a))
This PR is included in version 4.7.1 🎉 |
hi all -- while I greatly appreciate this fix (it's confused me for a long time), I'm concern that it has semi-silently landed in a patch fix. IMO, this is a breaking change, and even using the least egregious upgrade pattern ( I'm curious if there is a way to limit releasing breaking changes to (at a minimum) the minor version releases, even when it is a known-bug fix. unfortunately, this caused numerous functions to unexpectedly stop publishing, and I bet it is also affecting many many others without them noticing 😞 |
agreed! I suspect that this issue (#383) is a result of this change. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
ignore_changes = [function_version]
lifecycle should be in theno_refresh
resource. This PR will solve #281Fixes #281
Motivation and Context
Its behavior is currently opposite.
refresh_alias = true
should refresh new version to the alias.Breaking Changes
If anyone uses opposite
refresh_alias = false
as a workaround to refresh version, one needs to update totrue
and vice versa.How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)pyenv
so I update to Node.js example insteadprovisioned_concurrent_executions
in the example was1
after run the secondapply
it will failed not allowed to be lower than10
. This is unrelated toalias
example. So removed from the example.examples/*
projectsterraform
init
,plan
thenapply
../fixtures/nodejs14.x-app1/index.js
terraform apply
- [x] I have executed `pre-commit run -a` on my pull request