Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --samples_per_plugin to specify explicit sampling counts #1138

Merged
merged 1 commit into from Apr 18, 2018
Merged

Add --samples_per_plugin to specify explicit sampling counts #1138

merged 1 commit into from Apr 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2018

Add TensorBoard flag samples_per_plugin that allows for custom specification of samples to keep per summary type.

Previously, TensorBoard always downsampled summaries for OOM reasons but some users wanted the ability to keep all their summaries of some types.

With this flag, --samples_per_plugin='histogram=2,images=0'
keeps TensorBoard defaults for other summaries, restricts the number of histograms to 2, and keeps all image summaries.

…ification of samples to keep per summary type.

Previously, TensorBoard always downsampled summaries for OOM reasons but some users wanted the ability to keep all their summaries of some types.

With this flag, --samples_per_plugin='histogram=2,images=0'
 keeps TensorBoard defaults for other summaries, restricts the number of histograms to 2, and keeps all image summaries.
@nfelt nfelt changed the title Add TensorBoard flag samples_per_plugin that allows for custom spec… Add --samples_per_plugin to specify sampling counts per plugin Apr 18, 2018
@nfelt nfelt changed the title Add --samples_per_plugin to specify sampling counts per plugin Add --samples_per_plugin to specify explicit sampling counts Apr 18, 2018
@nfelt nfelt merged commit 01ce9b9 into tensorflow:master Apr 18, 2018
@linzhiqiu
Copy link

If using tensorboard-pytorch, how can one upgrade the tensorboard to 1.9.0 in order to use this feature?

@nfelt
Copy link
Contributor

nfelt commented Jun 25, 2018

@linzhiqiu We have no affiliation with tensorboard-pytorch, but as far as I can tell it looks like tensorboard-pytorch primarily offers a PyTorch-compatible way to write summary data to event files, which you'd then view with regular TensorBoard. So however you're getting TensorBoard now, you would just update it. If you're getting TensorBoard as part of a TensorFlow installation via pip then you would just pip install tensorboard==1.9.0.

@jperl
Copy link

jperl commented Jul 25, 2018

Thank you so much for this feature. I was about to manually export all the images, this is 100x better. 😍

@ghost
Copy link
Author

ghost commented Jul 27, 2018 via email

wchargin added a commit that referenced this pull request Aug 18, 2020
Summary:
Before `--samples_per_plugin` existed, the only way to change the
sampling thresholds was to patch `application.py` manually. But the flag
has been the right way to do this since #1138, and manual patching has
been insufficient since the flag value was exposed to plugins in #3271.
There’s no need to discuss this implementation detail any more.

wchargin-branch: readme-remove-application-reference
wchargin-source: b79027ec8b279537bdf38f7b5d7f36cf5dd38498
wchargin added a commit that referenced this pull request Aug 18, 2020
Summary:
Before `--samples_per_plugin` existed, the only way to change the
sampling thresholds was to patch `application.py` manually. But the flag
has been the right way to do this since #1138, and manual patching has
been insufficient since the flag value was exposed to plugins in #3271.
There’s no need to discuss this implementation detail any more.

wchargin-branch: readme-remove-application-reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants