Added support for TenableAD LDAP Configuration APIs #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMcGrath
added
documentation
tenable/ad/ldap_configuration/api.py
Outdated
Comment on lines
41
to
60
| enabled (optional, bool): | ||
| ??? | ||
| url (optional, str): | ||
| ??? | ||
| search_user_dn (optional, str): | ||
| ??? | ||
| search_user_password (optional, str): | ||
| ??? | ||
| user_search_base (optional, str): | ||
| ??? | ||
| user_search_filter (optional, str): | ||
| ??? | ||
| allowed_groups (optional, List[Dict]): | ||
| The below listed params are expected in allowed groups dict. | ||
| name (required, str): | ||
| ??? | ||
| default_role_ids (required, List[int]): | ||
| ??? | ||
| default_profile_id (required, int): | ||
| ??? |
There was a problem hiding this comment.
Ideally we should work out what these fields are and document them.
There was a problem hiding this comment.
We have updated param documentations.
updated url in test updated last word uppercase logic removed unused import updated param descriptions changed required field schema validation
tushar-balwani
force-pushed
the
feature/tenable.ad-ldap_configuration
branch
from
fd26543
to
863cd73
Compare
SteveMcGrath
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
Tenable.AD LDAP Configuration APIsupdated docs to support ldap configuration api details
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: