Skip to content

Commit

Permalink
Add remiaining ValueTypeTests for lw5
Browse files Browse the repository at this point in the history
All are passing except for testDefaultValueIn*Array tests, vm changes coming for this in a seperate pull request.
The next step after this is to update my local lw5 to where aconst_init and withfield to update the rest of the tests.

Not added to lw5:
testDefaultValueWithNonValueType - testing runtime check for aconst_init
testMethodTypeDescriptorRef - testing change for qtypes
testMethodTypeDescriptorValue - testing change for qtypes
testUnresolvedDefaultValueUse - aconst_init test
testUnresolvedWithFieldUse - withfield test
testPrimitiveClassHashCode
testCheckCastValueTypeOnInvalidQtype
Rename testCheckCastValueTypeOnInvalidLtype -> testCheckCastValueTypeOnInvalidClass
testCheckCastValueTypeOnNull - doesn't apply to nullrestricted
testDefaultValueInPointByteCodeMultiArray
testDefaultValueInLineByteCodeMultiArray
testDefaultValueInTriangleByteCodeMultiArray

Rename ValueTypeGenerator.generateIllegalValueClassWithSychMethods tp ValueTypeGenerator.generateIllegalValueClassWithSynchMethods

Signed-off-by: Theresa Mammarella <[email protected]>
  • Loading branch information
theresa-m committed Nov 23, 2023
1 parent 9436c9d commit 2320723
Show file tree
Hide file tree
Showing 4 changed files with 1,703 additions and 235 deletions.
1 change: 1 addition & 0 deletions test/functional/Valhalla/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
<!-- <src path="${src_lw5}"/> -->
<src path="${transformerListener}" />
<compilerarg line='--add-exports java.base/jdk.internal.misc=ALL-UNNAMED --add-exports java.base/jdk.internal.value=ALL-UNNAMED' />
<compilerarg line='--enable-preview -source 22'/>
<!-- Also remove this line when running lw5 -->
<compilerarg line='-source 22 -XDenablePrimitiveClasses' />
<classpath>
Expand Down
2 changes: 1 addition & 1 deletion test/functional/Valhalla/playlist.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<variation>-Xnocompressedrefs -Xgcpolicy:gencon</variation>
</variations>
<command>$(JAVA_COMMAND) $(JVM_OPTIONS) \
-Xint \
-Xint --enable-preview \
--add-opens java.base/jdk.internal.misc=ALL-UNNAMED \
--add-exports java.base/jdk.internal.value=ALL-UNNAMED \
-cp $(Q)$(LIB_DIR)$(D)asm.jar$(P)$(RESOURCES_DIR)$(P)$(TESTNG)$(P)$(TEST_RESROOT)$(D)ValhallaTests.jar$(Q) \
Expand Down
Loading

0 comments on commit 2320723

Please sign in to comment.