Fix a deadlock and keep the semantics of wait_timeout in wait_queue unchanged #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuYang261
changed the title
AuYang261
force-pushed
the
dev
branch
2 times, most recently
from
dd59f2e
to
4f77140
Compare
coolyjg
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the calling of
current().destroy_keys()toaxtask::api::exit()beforeRUN_QUEUEbeing locked, thus solving the deadlock in tsd destroying function.And I changed
axtask::wait_queue::wait_timeoutback to its original semantics.