-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): remove linting temp, and always build on docker changes #94
Conversation
WalkthroughWalkthroughThe recent updates streamline workflow processes by refining cache settings, specifying triggering file paths, and commenting out specific test sections. These changes enhance the efficiency and organization of Docker publishing and workflow management within the GitHub Actions environment. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/binaries-publish.yaml (1 hunks)
- .github/workflows/docker-publish-rootless.yaml (2 hunks)
- .github/workflows/docker-publish.yaml (2 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/binaries-publish.yaml
- .github/workflows/docker-publish-rootless.yaml
Additional comments not posted (2)
.github/workflows/docker-publish.yaml (2)
11-14
: Excellent addition of Docker-related paths to workflow triggers.Including
Dockerfile
,Dockerfile.rootless
,.dockerignore
, and.github/workflows
ensures that relevant changes trigger the workflow, enhancing its efficiency and accuracy.Also applies to: 22-25
92-93
: Verify the intent behind commenting out cache settings.Commenting out the cache settings could be a temporary measure to address the cache build issues. Ensure to revisit and re-enable these settings once the issue is resolved for optimized workflow performance.
Hopefully fixes weird cache build issues and also temp removes the lint checks for the binary releases.
Summary by CodeRabbit