test: cluster-setup-master online workers check

Previously a `checks.workers` boolean was conditionally set, but never checked. Additionally, it was never actually set because `cluster.onlineWorkers` is always undefined. PR-URL: nodejs#6535 Reviewed-By: Anna Henningsen <[email protected]>
sxa · May 17, 2016 · 149bea0 · 149bea0
1 parent 377eb22
commit 149bea0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/test/parallel/test-cluster-setup-master.js b/test/parallel/test-cluster-setup-master.js
@@ -17,6 +17,7 @@ if (cluster.isWorker) {
   };
 
   var totalWorkers = 2;
+  var onlineWorkers = 0;
 
   // Setup master
   cluster.setupMaster({
@@ -40,6 +41,8 @@ if (cluster.isWorker) {
 
   cluster.on('online', function lisenter(worker) {
 
+    onlineWorkers++;
+
     worker.once('message', function(data) {
       correctIn += (data === 'custom argument' ? 1 : 0);
       if (correctIn === totalWorkers) {
@@ -49,7 +52,7 @@ if (cluster.isWorker) {
     });
 
     // All workers are online
-    if (cluster.onlineWorkers === totalWorkers) {
+    if (onlineWorkers === totalWorkers) {
       checks.workers = true;
     }
   });
@@ -60,6 +63,7 @@ if (cluster.isWorker) {
 
   // Check all values
   process.once('exit', function() {
+    assert.ok(checks.workers, 'Not all workers went online');
     assert.ok(checks.args, 'The arguments was noy send to the worker');
     assert.ok(checks.setupEvent, 'The setup event was never emitted');
     var m = 'The settingsObject do not have correct properties';