Skip to content

Commit

Permalink
build: disable -Wattributes warnings on aix
Browse files Browse the repository at this point in the history
Disable the following compiler warning:

    warning: visibility attribute not supported in this
    configuration; ignored [-Wattributes]

This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.

PR-URL: nodejs#32419
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
  • Loading branch information
bnoordhuis authored and addaleax committed Mar 29, 2020
1 parent cd1db2d commit 037f844
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,15 @@
'-Wl,-brtl',
],
}, { # else it's `AIX`
# Disable the following compiler warning:
#
# warning: visibility attribute not supported in this
# configuration; ignored [-Wattributes]
#
# This is gcc complaining about __attribute((visibility("default"))
# in static library builds. Legitimate but harmless and it drowns
# out more relevant warnings.
'cflags': [ '-Wno-attributes' ],
'ldflags': [
'-Wl,-blibpath:/usr/lib:/lib:/opt/freeware/lib/pthread/ppc64',
],
Expand Down

0 comments on commit 037f844

Please sign in to comment.