correcting bug in omnitest #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, Bill. Merging now.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stray exclamation point prevented an if statement from executing at the proper time. In terms of results, this mattered only when both a correct expression and a correct value were given, in which case it failed to check the value. This usage of omnitest being rare, it was not noticed until testing Statistical Inference.
The affected if statement could have been removed completely with slight loss of efficiency but without loss of function, but instead I've just corrected the typo. The fix has been tested on about half dozen lessons in Statistical Inference. It seems ready to merge.