Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: sync to latest napi workflow #2592

Merged
merged 1 commit into from
Oct 31, 2021
Merged

ci: sync to latest napi workflow #2592

merged 1 commit into from
Oct 31, 2021

Conversation

Brooooooklyn
Copy link
Member

kdy1
kdy1 approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 merged commit 1a659d3 into swc-project:master Oct 31, 2021
@Songkeys
Copy link
Contributor

Songkeys commented Nov 3, 2021

This PR makes @swc/[email protected] totally break. (1.2.105 is fine.)

After installing @swc/core, there's no platform-specific core binding installed. Checked on my macOS and linux x64. Please take a look.

@Brooooooklyn
Copy link
Member Author

image

@Brooooooklyn
Copy link
Member Author

@Songkeys I've confirmed this is because our internal npm registry is out of synced for all optioanlDependencies in @swc/core.

@Songkeys
Copy link
Contributor

Songkeys commented Nov 3, 2021

@Brooooooklyn You were right. Sorry about this. This is really confusing... Could we make this error behaviour clearer?

@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brooooooklyn @Songkeys @kdy1