Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Commit

Permalink
mm-add-comment-for-__mod_zone_page_stat-checkpatch-fixes
Browse files Browse the repository at this point in the history
also fix spellos

WARNING: line over 80 characters
torvalds#54: FILE: mm/rmap.c:988:
+		 * pte lock(a spinlock) is held, which implies preemtion disabled.

total: 0 errors, 1 warnings, 45 lines checked

./patches/mm-add-comment-for-__mod_zone_page_stat.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Hugh Dickins <[email protected]>
Cc: Jianyu Zhan <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
akpm00 authored and sfrothwell committed May 17, 2014
1 parent 6d4480e commit 377a0f1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions mm/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,9 @@ static inline int mlocked_vma_newpage(struct vm_area_struct *vma,

if (!TestSetPageMlocked(page)) {
/*
* We use the irq-unsafe __mod_zone_page_stat because
* this counter is not modified from interrupt context, and the
* pte lock is held(spinlock), which implies preemtion disabled.
* We use the irq-unsafe __mod_zone_page_stat because this
* counter is not modified from interrupt context, and the pte
* lock is held(spinlock), which implies preemption disabled.
*/
__mod_zone_page_state(page_zone(page), NR_MLOCK,
hpage_nr_pages(page));
Expand Down
5 changes: 3 additions & 2 deletions mm/rmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,8 @@ void do_page_add_anon_rmap(struct page *page,
/*
* We use the irq-unsafe __{inc|mod}_zone_page_stat because
* these counters are not modified in interrupt context, and
* pte lock(a spinlock) is held, which implies preemtion disabled.
* pte lock(a spinlock) is held, which implies preemption
* disabled.
*/
if (PageTransHuge(page))
__inc_zone_page_state(page,
Expand Down Expand Up @@ -1082,7 +1083,7 @@ void page_remove_rmap(struct page *page)
* We use the irq-unsafe __{inc|mod}_zone_page_stat because
* these counters are not modified in interrupt context, and
* these counters are not modified in interrupt context, and
* pte lock(a spinlock) is held, which implies preemtion disabled.
* pte lock(a spinlock) is held, which implies preemption disabled.
*/
if (unlikely(PageHuge(page)))
goto out;
Expand Down

0 comments on commit 377a0f1

Please sign in to comment.