Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict Typescript output of discriminator (PHNX-805) (#1) #8157

Merged
merged 1 commit into from
May 10, 2018

Conversation

gbrown-ce
Copy link
Contributor

@gbrown-ce gbrown-ce commented May 8, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Motivation

The current release of swagger-codegen does not output valid strict typescript for discriminators

Modifications

Updating the discriminator output to be valid strict typescript

Motivation
----
The current release of swagger-codegen does not output valid strict typescript for discriminators

Modifications
----
Updating the discriminator output to be valid strict typescript
@gbrown-ce
Copy link
Contributor Author

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny

There is a similar PR that has been stagnant for a couple of months (#7824), so I figured I'd try to get this put through.

@wing328 wing328 added this to the v2.4.0 milestone May 10, 2018
@wing328 wing328 merged commit 6bd95e7 into swagger-api:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants