Fix for uncompilable java client if no model definitions is specified … #8123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wagger-api#7836) After fixes for swagger-api#6636 the gson based clients would not compile if the swagger json did not have any model definitions. This can be the case if the API only uses simple datastructures for input and output. (int, String, List, Map etc.)
|
@jeff9finger for review. |
eivinhb
changed the title
|
To test: |
|
@jeff9finger What does it take to get this merged now? Is there anything I can do? |
|
It is up to someone who has authority to merge it. |
|
thanks a lot @eivinhb ! |
frantuma
added a commit
that referenced
this pull request
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#7836)
After fixes for #6636 the gson based clients would not compile if the
swagger json did not have any model definitions. This can be the case
if the API only uses simple datastructures for input and output. (int,
String, List, Map etc.)
I have not updated the pet-store-clients for this PR. The reason is that the change does not affect the pet store api in any way, since this is fix is for apis with no model definitions.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)