Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12135 - Upgrading slf4j to latest #12194

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

jeremydyoung
Copy link

PR checklist

  • [ Yes ] Read the contribution guidelines.
  • [ N/A ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ Yes ] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [ N/A ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

I have verified that both options of downgrading logback to 1.2.12 and upgrading slf4j to 2.0.7 solve the logging problems experienced with the cli. This PR is suggesting an upgrade to slf4j, but may technically be riskier than the logback downgrade. Fortunately the logback downgrade is similarly trivial, and could be employed as an alternative.

This has been broken since 3.0.42 on April 5, 2023, which is impacting all brew users of the swagger-codegen cli.

@matecsaj
Copy link

matecsaj commented Jul 8, 2023

Thanks, Jeremy!

@jeremydyoung
Copy link
Author

You're welcome. I was already fighting with it and trying to figure out the problem, so I figured I'd share a solution. Here's hoping it gets reviewed and merged 🤞

@HugoMario
Copy link
Contributor

thanks a lot @jeremydyoung !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants