fix: Remove error parameter on _triggerChanError
#637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
When the device is offline,
SocketExceptions
andWebSocketExceptions
gets thrown by the websocket connection stream here. This was causing rapid errors to be passed to the.subscribe()
callback, and therefore causing rapid errors to be thrown when listening to data changes using.stream()
method.What is the new behavior?
The errors from the web socket connection is not passed to
_triggerChanError
, which is aligned with the js SDK https://github.com/supabase/realtime-js/blob/master/src/RealtimeClient.ts#L402Additional context
This PR reverts some of the work done in https://github.com/supabase/realtime-dart/pull/62/files, but we can default to the same behavior as the js SDK for now and fix things if necessary in the future.