Rename example webspace to something more general #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/rename-example-webspace
branch
from
5ff530b
to
b451017
Compare
alexander-schranz
requested review from
chirimoya,
wachterjohannes,
martinlagler and
Prokyonn
chirimoya
approved these changes
Jun 6, 2024
Prokyonn
approved these changes
Jun 6, 2024
wachterjohannes
approved these changes
Jun 27, 2024
martinlagler
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Rename example webspace to something more general.
Why?
A more general name avoids hard migrations like renaming a webspace later.
The current webspace is named
examplewhich forces most to rename it. But mostly we should make the start as easy as possible and go with something which may matches most single webspace installations.Options which did come to my mind:
generalmainwebsite(other webspaces could beblogorintranet)defaultbase@sulu/core-developer what do you think?