Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flex recipes #23

Merged
merged 6 commits into from
Dec 11, 2019
Merged

Update flex recipes #23

merged 6 commits into from
Dec 11, 2019

Conversation

alexander-schranz
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes -
Related issues/PRs -
License MIT
Documentation PR -

What's in this PR?

Update routing and twig recipes.

Why?

Currently the following new files are created by symfony flex which are not in our repository.

To Do

  • Create PR for sulu/sulu test skeleton

@alexander-schranz alexander-schranz added the enhancement New feature or request label Nov 19, 2019
@danrot danrot mentioned this pull request Dec 10, 2019
Closed
1 task
@alexander-schranz alexander-schranz changed the title Update routing and twig recipes Update flex recipes Dec 10, 2019
@danrot
Copy link
Contributor

danrot commented Dec 10, 2019

  1. Aren't we adding the AppFixtures now? In general I am still wondering if we should not removing all the auto-configured files and maybe add them to the .gitignore file? Then we would not have any problems while developing, and the .gitignore file is changed when executing a composer create-project anyway, meaning that it would not affect projects.
  2. Do we want to make these changes now also in the sulu/sulu repository? Then I would leave that one open and merge them together, just to make sure nothing is forgotten.

@danrot danrot merged commit 723a99d into sulu:release/2.0 Dec 11, 2019
@danrot danrot mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danrot danrot danrot approved these changes

@wachterjohannes wachterjohannes Awaiting requested review from wachterjohannes

Assignees

@wachterjohannes wachterjohannes

@alexander-schranz alexander-schranz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-schranz @danrot @wachterjohannes