Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to avoid registering Controller for both contexts #19

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Allow to avoid registering Controller for both contexts #19

merged 1 commit into from
Oct 30, 2019

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Oct 30, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs ---
License MIT
Documentation PR ---

What's in this PR?

This PR configures the Controllers to be in a Admin and a Website folder. Depending on which folder is chosen it is only registered in one of both contexts.

Why?

Because some Controller make use of services that are not registered in the given context, the application will crash with an error message complaining about this missing service.

Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add a comment what the sulu context does

@alexander-schranz alexander-schranz added the enhancement New feature or request label Oct 30, 2019
@alexander-schranz alexander-schranz merged commit 7ca7104 into sulu:release/2.0 Oct 30, 2019
@danrot danrot deleted the enhancement/admin-controller-configuration branch October 30, 2019 13:12
@danrot danrot mentioned this pull request Nov 25, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants