Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Stronger type checks on user input #378

Merged
merged 2 commits into from Apr 30, 2024
Merged

Add: Stronger type checks on user input #378

merged 2 commits into from Apr 30, 2024

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

More precise checking of data sent by users.

Why?

We have had the problem that bots have transferred a string instead of an array. This caused the builder to run into the error Cannot access offset of type string on string

Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, some small code style change request.

Form/Builder.php Outdated Show resolved Hide resolved
@alexander-schranz alexander-schranz merged commit 97b00a9 into sulu:2.5 Apr 30, 2024
4 of 5 checks passed
@alexander-schranz
Copy link
Member

@flogado Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants