Fix file type attr #328
Fix file type attr #328
Conversation
max attr is no only applicable on `date` `month` `week` `time` `datetime-local` `number` `range` input types accept attr should not be empty, when all files are accepted the attribute should be removed
Dynamic/Types/AttachmentType.php
Outdated
|
|
||
| $options['attr']['max'] = $fileMax; |
There was a problem hiding this comment.
Remove this would be a bc break and would crash form themes try to read this attribute to be displayed as value on the website.
At current state we can only add a comment to // @deprecated this and add a line to the UPGRADE.md to remove it in the next major.
For your website you can filter out that attribute in your custom form theme if you don't want to render it.
There was a problem hiding this comment.
Hello, my bad I totally forgot that use case. I added a new "data-max" attribute to allow people who have this use case to have this possibility. Should I add something to UPGRADE.md or let you handle it when you will prepare the release ?
There was a problem hiding this comment.
yeah a sentence in the UPGRADE.md would be great about it.
| if (!empty($mimeTypes)) { | ||
| $options['attr']['accept'] = \implode(',', $mimeTypes); | ||
| } |
|
@RealAestan Thank you! |
What's in this PR?
The attribute max is removed on input type file
The attribute accept is removed when there is not restrictions on input file type
Why?
max attr is no only applicable on
datemonthweektimedatetime-localnumberrangeinput typesaccept attr should not be empty, when all files are accepted the attribute should be removed