Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dynamic entity to basic fields #236

Merged

Conversation

Prokyonn
Copy link
Member

@Prokyonn Prokyonn commented Apr 7, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Adjusts the database columns to have a consistent data set.

Why?

The database table is much more readable with less columns and some columns had keywords for MySql 8 as their name.

To Do

  • Update CHANGELOG.md
  • Create documentation

@alexander-schranz
Copy link
Member

alexander-schranz commented Apr 7, 2020

@Prokyonn as this is use break its also the best that we rename in this pull request the composer package from sulu/sulu-form-bundle to sulu/form-bundle #223 (documentation need to be adjusted).

EDIT: Think we need todo that on lowest branch can you create a Pull request on master release/0.1 for this, which we merge before this PR.

Entity/Dynamic.php Outdated Show resolved Hide resolved
UPGRADE.md Show resolved Hide resolved
UPGRADE.md Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
@alexander-schranz alexander-schranz merged commit 3dda4f8 into sulu:develop Apr 8, 2020
@Prokyonn Prokyonn deleted the enhancement/database-consistency branch June 9, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants