-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rulesets): add AsyncAPI v3 support #2697
Open
jonaslagoni
wants to merge
6
commits into
stoplightio:develop
Choose a base branch
from
jonaslagoni:add_asyncapi_v3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
changed the title
feat: add AsyncAPI v3 support
feat(rulesets): add AsyncAPI v3 support
Sep 23, 2024
jonaslagoni
force-pushed
the
add_asyncapi_v3
branch
from
September 23, 2024 16:54
9590abc
to
ef5a264
Compare
jonaslagoni
force-pushed
the
add_asyncapi_v3
branch
from
September 24, 2024 09:47
6f55c0b
to
e19da87
Compare
The last CircleCI test are simply timing out, no idea how to fix that. All ready to be reviewed. |
jonaslagoni
force-pushed
the
add_asyncapi_v3
branch
from
September 24, 2024 10:18
5c95cb1
to
b87d147
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Some minor remarks:
- Formats Package:
- Bump package version to
1.8.0
- Update deps in consuming packages: functions, ruleset-bundler, rulesets, and core (devDependencies)
- Bump package version to
- Rulesets Package:
- Bump package version to
1.21.0
- Bump package version to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2559.
Checklist
Does this PR introduce a breaking change?
Additional context
Does not update the following rules:
Limits to rules: