Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript Unit Tests #533

Merged
merged 16 commits into from
Dec 8, 2020
Merged

TypeScript Unit Tests #533

merged 16 commits into from
Dec 8, 2020

Conversation

steveukx
Copy link
Owner

@steveukx steveukx commented Dec 1, 2020

  • Standardises use of helper methods in tests: create with newSimpleGit and close with closeWithSuccess / closeWithError
  • Converts more unit tests to TypeScript
  • Creates TypeScript task generators for diffSummary, log and stashList
  • Refactors some internal Task types to be separate from their implementations and therefore importable independently

@steveukx
Convert unit tests to TypeScript and update types to match additional…
ab8eb2e 
… usage patterns
@steveukx
Convert methods diff, diffSummary, log to TypeScript
1150fc7 
Fix types for `stashList`, `LogResult`
Deprecate `ListLogSummary` (now an alias of `LogResult`)

- Auto-mock `@kwsites/file-exists`
- Remove `sinon` dependency
@steveukx
- Fix path to SimpleGitTask and associated types
53e3b23
@steveukx
Create stashListTask to reuse the new logTask
4231be7
@steveukx
- Fix path to StringTask
8d7d51f 
- Fix log hash test
@steveukx
Update types for catFile to match possible use case of callback wit…
48061a7 
…h no options

Auto mock `@kwsites/file-exists`, allowing optional pass through to real library
Remove instance fixtures from setup.js
Standardise use of `newSimpleGit`, `closeWithSuccess` and `closeWithError` in tests instead of `Instance`, `closeWith` and `errorWith`
@steveukx
Switch to 'real' mode for @kwsites/file-exists in integration tests
b745f13 
Auto-reset `@kwsites/file-exists` mock after each test
@steveukx
Set pre-version builder to use non-composite build
1e1c5ba
@steveukx
Additional tests converted to TypeScript
9e4aa93
@steveukx
- Convert git.commit and git.fetch to TypeScript parsers and upda…
7f9809f 
…tes types for their usage

- Fix bug in parsing of `git.commit` response where committing only deletions would list the lines changed as insertions instead.
- `parseStringResponse` to accept varargs of strings to run against, to allow for more easily running the same parser against both stdOut and stdErr
- Finally removes legacy response handlers and all usages in `git` itself
@steveukx
Switch git.checkIgnore to using an inline task
b146f73
@steveukx
Fix types for git submodule based methods
71dea81
@steveukx
Allow regular expression in assertGitError message
0401a4b 
Unit tests all converted to TypeScript
Update types to match functionality in `addRemote`, `getRemotes`, `raw`, `reset`, `status`
@steveukx
Update changelog and readme, adds timeline for deprecations being rem…
c7a5f65 
…oved to warning messages (ie: v3)
@steveukx
Remove legacy setup.js and use of jestify-node-unit
e2552da
@steveukx
Share test utilities (like / wait and error assertions) between u…
0fc658b 
…nit/integration and consumer tests
@steveukx steveukx merged commit f4a01a8 into main Dec 8, 2020
@steveukx steveukx deleted the ts-tests branch December 8, 2020 08:09
@steveukx steveukx mentioned this pull request Dec 14, 2020
Merged
@lGSMl lGSMl mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@steveukx