[ANCHOR-752] Remove amount_out requirement in RequestOnchainFunds #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
approved these changes
Aug 8, 2024
JakeUrban
reviewed
Aug 8, 2024
Comment on lines
143
to
145
| if (request.getAmountOut() == null && txn.getAmountOut() == null) { | ||
| throw new InvalidParamsException("amount_out is required"); | ||
| } |
There was a problem hiding this comment.
Shouldn't we require amount_out when a quote was used or when amount_in_asset == amount_out_asset?
There was a problem hiding this comment.
Good point. I think we should require amount_out if there was no quote as well
There was a problem hiding this comment.
I don't think we can require amount_out if there was no quote, since the business doesn't have to commit to a payout amount until its about to send funds. The exception is if amount_out_asset = amount_in_asset, since its always 1:1 minus fees.
There was a problem hiding this comment.
Sorry we should require either amount_out to be present either in request or in transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
amount_outis not set if a transaction has an associated indicative quote but has not yet received funds.Context
N/A
Testing
./gradlew testDocumentation
N/A
Known limitations
N/A