Add toggle instead of checkbox for addresses for permissions sheet #19424

ibrkhalil · 2024-03-27T18:17:59Z

fixes #19421
Follow up of #19296

Summary

Returns the toggle selector instead of checkbox.

status: ready

status-im-auto · 2024-03-27T18:23:05Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`dbcf3fa`	#1	2024-03-27 18:23:04	~4 min	`tests`	📄`log`
✔️	`dbcf3fa`	#1	2024-03-27 18:26:50	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`dbcf3fa`	#1	2024-03-27 18:26:52	~8 min	`android`	🤖`apk` 📲
✔️	`dbcf3fa`	#1	2024-03-27 18:28:01	~9 min	`ios`	📱`ipa` 📲

✔️	`7db66c0`	#2	2024-03-28 13:11:47	~4 min	`tests`	📄`log`
✔️	`7db66c0`	#2	2024-03-28 13:13:27	~6 min	`android`	🤖`apk` 📲
✔️	`7db66c0`	#2	2024-03-28 13:14:45	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`7db66c0`	#2	2024-03-28 13:16:25	~9 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`f4e3861`	#3	2024-03-28 15:01:33	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`f4e3861`	#3	2024-03-28 15:01:37	~8 min	`android`	🤖`apk` 📲
✔️	`f4e3861`	#3	2024-03-28 15:01:38	~8 min	`ios`	📱`ipa` 📲

✔️	`4eb8e0a`	#4	2024-03-28 15:24:55	~4 min	`tests`	📄`log`
✔️	`4eb8e0a`	#4	2024-03-28 15:28:42	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`4eb8e0a`	#4	2024-03-28 15:28:48	~8 min	`android`	🤖`apk` 📲
✔️	`4eb8e0a`	#4	2024-03-28 15:30:24	~9 min	`ios`	📱`ipa` 📲

status-im-auto · 2024-03-28T14:36:23Z

96% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Expected to fail tests: 1
Passed tests: 46

IDs of failed tests: 702844

IDs of expected to fail tests: 703503

Failed tests (1)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Device 2: Tap on found: SendMessageButton
Device 1: Getting preview message for link: https://m.youtube.com/watch?v=Je7yErjEVt4

critical/chats/test_public_chat_browsing.py:585: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    message.wait_for_element(60)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `PreviewMessage` by` xpath`: `//*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element

Device sessions

Device 1:

Device 2:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (46)

Click to expand

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

pavloburykh · 2024-03-28T15:13:44Z

@ibrkhalil thanx for the fix. E2E are okay.

…19424)

Add toggle instead of checkbox for addresses for permissions sheet

dbcf3fa

ibrkhalil self-assigned this Mar 27, 2024

ibrkhalil requested review from seanstrom, Parveshdhull and ulisesmac March 27, 2024 18:18

ibrkhalil added the request-manual-qa label Mar 27, 2024

ulisesmac approved these changes Mar 27, 2024

View reviewed changes

Merge branch 'develop' into 19421

7db66c0

ibrkhalil added skip-manual-qa and removed request-manual-qa labels Mar 28, 2024

Parveshdhull approved these changes Mar 28, 2024

View reviewed changes

Merge branch 'develop' into 19421

f4e3861

Merge branch 'develop' into 19421

4eb8e0a

ibrkhalil merged commit e6d9ef0 into develop Mar 28, 2024
6 checks passed

ibrkhalil deleted the 19421 branch March 28, 2024 15:40

mmilad75 pushed a commit that referenced this pull request Apr 2, 2024

Add toggle instead of checkbox for addresses for permissions sheet (#…

60bc998

…19424)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add toggle instead of checkbox for addresses for permissions sheet #19424

Add toggle instead of checkbox for addresses for permissions sheet #19424

ibrkhalil commented Mar 27, 2024

status-im-auto commented Mar 27, 2024 •

edited

Loading

status-im-auto commented Mar 28, 2024

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

pavloburykh commented Mar 28, 2024

Add toggle instead of checkbox for addresses for permissions sheet #19424

Add toggle instead of checkbox for addresses for permissions sheet #19424

Conversation

ibrkhalil commented Mar 27, 2024

Summary

status-im-auto commented Mar 27, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Mar 28, 2024

96% of end-end tests have passed

Failed tests (1)

Class TestCommunityMultipleDeviceMerged:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (46)

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

pavloburykh commented Mar 28, 2024

status-im-auto commented Mar 27, 2024 •

edited

Loading