Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make integration tests more enjoyable to use #19025

Merged
merged 14 commits into from
Mar 5, 2024
Merged

Make integration tests more enjoyable to use #19025

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2ce3496
Rewrite integration tests without lib day8.re-frame/test
ilmotta Feb 26, 2024
43835b3
Rewrite tests to use promesa
ilmotta Feb 26, 2024
63dcf6e
Log full keyword instead of just its name
ilmotta Feb 27, 2024
b3564e8
Respect order of expected event IDs
ilmotta Feb 27, 2024
d0c3a54
Renaming and reject with a better error message
ilmotta Feb 27, 2024
6bd75cf
Fail fast when int tests fail and support silencing re-frame debug me…
ilmotta Feb 27, 2024
fcf84d7
Make fail-fast behavior configurable and merge two functions
ilmotta Feb 27, 2024
9cbbc7f
Update zprint rule for h/integration-test
ilmotta Feb 27, 2024
097f4ad
Add docstrings to fixtures
ilmotta Feb 27, 2024
389b40a
Allow integration tests to time out (default 60s)
ilmotta Feb 27, 2024
8865e0d
Improve docstrings
ilmotta Feb 27, 2024
d658fa4
Rename fixture
ilmotta Mar 1, 2024
33f4c35
Document the done function will be passed to f
ilmotta Mar 1, 2024
f4781c9
Use promesa create instead of interop
ilmotta Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use promesa create instead of interop
  • Loading branch information
@ilmotta
ilmotta committed Mar 5, 2024
commit f4781c9c54a519e0df8c75c2b84a629c2150b4d3
2 changes: 1 addition & 1 deletion src/test_helpers/integration.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
(wait-for event-ids default-re-frame-wait-for-timeout-ms))
([event-ids timeout-ms]
(let [waiting-ids (atom event-ids)]
(js/Promise.
(p/create
(fn [promise-resolve promise-reject]
(let [cb-id (gensym "post-event-callback")
timer-id (js/setTimeout (fn []
Expand Down