Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#18608] Collectibles fetching performance #18921

Merged
merged 14 commits into from
Mar 7, 2024
Merged

[#18608] Collectibles fetching performance #18921

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
49d4fd7
Add memoized versions to convert keys
ulisesmac Feb 19, 2024
d97903e
Add placeholder for SVG collectibles due to errors and warnings
ulisesmac Feb 19, 2024
d391b8f
Add events to request collectibles per account
ulisesmac Feb 19, 2024
818b79c
Update sub to list all accounts collectibles evenly
ulisesmac Feb 19, 2024
3256ff2
Update collectibles tab to pull new data when end is reached
ulisesmac Feb 19, 2024
80c0fc3
Use memoized version of key transformation
ulisesmac Feb 19, 2024
80694af
Lint fix
ulisesmac Feb 19, 2024
2fc9db4
Remove `displayable-collectibles?` test adds one for the flush one
ulisesmac Feb 20, 2024
ac0e5d7
Lint fix
ulisesmac Feb 20, 2024
1317488
fix
ulisesmac Mar 4, 2024
95256da
Avoid collisions for collectibles request and handle failed requests
ulisesmac Mar 5, 2024
1942f24
Lint fix
ulisesmac Mar 5, 2024
0aa5f73
Add a more robust unique ID implementation
ulisesmac Mar 5, 2024
2941746
Lint fix
ulisesmac Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove displayable-collectibles? test adds one for the flush one
  • Loading branch information
@ulisesmac
ulisesmac committed Mar 7, 2024
commit 2fc9db40e7413318209f0d7e897085b2dc291826
33 changes: 11 additions & 22 deletions src/status_im/contexts/wallet/events_test.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,24 +56,8 @@
(is (match? (:db effects) expected-db))))

(deftest store-collectibles
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test updated

(testing "(displayable-collectible?) helper function"
(let [expected-results [[true
{:collectible-data {:image-url "https://..." :animation-url "https://..."}}]
[true {:collectible-data {:image-url "" :animation-url "https://..."}}]
[true {:collectible-data {:image-url nil :animation-url "https://..."}}]
[true {:collectible-data {:image-url "https://..." :animation-url ""}}]
[true {:collectible-data {:image-url "https://..." :animation-url nil}}]
[false {:collectible-data {:image-url "" :animation-url nil}}]
[false {:collectible-data {:image-url nil :animation-url nil}}]
[false {:collectible-data {:image-url nil :animation-url ""}}]
[false {:collectible-data {:image-url "" :animation-url ""}}]]]
(doseq [[result collection] expected-results]
(is (match? result (collectibles/displayable-collectible? collection))))))

(testing "save-collectibles-request-details"
(let [db {:wallet {:accounts {"0x1" {}
"0x3" {}}}}
collectible-1 {:collectible-data {:image-url "https://..." :animation-url "https://..."}
(testing "flush-collectibles"
(let [collectible-1 {:collectible-data {:image-url "https://..." :animation-url "https://..."}
:ownership [{:address "0x1"
:balance "1"}]}
collectible-2 {:collectible-data {:image-url "" :animation-url "https://..."}
Expand All @@ -82,12 +66,17 @@
collectible-3 {:collectible-data {:image-url "" :animation-url nil}
:ownership [{:address "0x2"
:balance "1"}]}
collectibles [collectible-1 collectible-2 collectible-3]
expected-db {:wallet {:accounts {"0x1" {:collectibles (list collectible-2 collectible-1)}
db {:wallet {:ui {:collectibles {:pending-requests 0
:fetched {"0x1" [collectible-1 collectible-2]
"0x2" [collectible-3]}}}
:accounts {"0x1" {}
"0x3" {}}}}
expected-db {:wallet {:ui {:collectibles {}}
:accounts {"0x1" {:collectibles (list collectible-1 collectible-2)}
"0x2" {:collectibles (list collectible-3)}
"0x3" {}}}}
effects (collectibles/store-collectibles {:db db} [collectibles])
result-db (:db effects)]
result-db (:db (collectibles/flush-collectibles {:db db}))]

(is (match? result-db expected-db)))))

(deftest clear-stored-collectibles
Expand Down