chore: fix few outdated things in docs & readme #18920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
force-pushed
the
update-docs-and-main-readme
branch
from
f0a8f3c
to
da6e60d
Compare
flexsurfer
reviewed
Feb 20, 2024
siddarthkay
force-pushed
the
update-docs-and-main-readme
branch
from
da6e60d
to
5425c9d
Compare
Jenkins BuildsClick to see older builds (7)
|
vkjr
reviewed
Feb 20, 2024
J-Son89
reviewed
Feb 20, 2024
J-Son89
reviewed
Feb 20, 2024
jakubgs
reviewed
Feb 20, 2024
ilmotta
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Thank you! Always important work. Apart from a few formatting details (https://github.com/status-im/status-mobile/pull/18920/files#r1496194438), LGTM.
Parveshdhull
approved these changes
Feb 21, 2024
ulisesmac
approved these changes
Feb 21, 2024
siddarthkay
force-pushed
the
update-docs-and-main-readme
branch
from
5425c9d
to
1c6ad17
Compare
In this commit we brings docs upto speed on a few things : - remove technical doc link from old website - update steps on how to build the app for physical iOS device - update steps on new workflow to build app without needing `make run-metro` - remove info about disabling `hermes` - Add information about running integration and unit tests separately - update getting started steps
siddarthkay
force-pushed
the
update-docs-and-main-readme
branch
from
3f47db8
to
fbf8a1d
Compare
ibrkhalil
pushed a commit
that referenced
this pull request
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we brings docs upto speed on a few things :
make run-metrohermesReview
To review open these links in a new window
status: ready