-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#16551] - shared community name in switcher #16576
Conversation
Jenkins BuildsClick to see older builds (5)
|
6a518c7
to
0d0203d
Compare
src/status_im2/contexts/shell/jump_to/components/switcher_cards/style.cljs
Show resolved
Hide resolved
src/status_im2/contexts/shell/jump_to/components/switcher_cards/view.cljs
Show resolved
Hide resolved
src/status_im2/contexts/shell/jump_to/components/switcher_cards/view.cljs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the context tags in Switcher cards and Activity Center. Looks Good!
Hey @ulisesmac , could you rebase this, please? |
0d0203d
to
6fbc3cc
Compare
Done! @qoqobolo |
75% of end-end tests have passed
Failed tests (9)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (27)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
22% of end-end tests have passed
Failed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
@ulisesmac thanx for the PR! One question: how have you been able to generate unread badges for community channel cards in Jump-to? For me unread badges do not appear neither in develop nor in this PR. |
@ulisesmac overall PR LGTM. Although I couldn't check the state with unread badge on channel card. But this issue is related to PR, we will log it separately. Ready for merge. |
6fbc3cc
to
ab8f83c
Compare
I showed them by modifying the code for testing 🤔 I don't know how to get them from the app too. |
fixes #16551
Summary
This PR fixes the community tag, and, while solving it, I noticed the channel card was looking bad too, so I fixed it too.
Mainly solves problems due to the layout.
Previously:
notifications | no notifications
In this PR:
notifications | no notifications
Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx
Review notes
I rewrote the layout of the bottom container in the switcher card because it we had many absolute styles, they weren't behaving as expected.
In the current solution, I preferred to make the component
context-tag
more flexible, since I was breaking many styles in other uses of this tag.We will need also to solve this new issue:
We must create all missing context tags variants.
Platforms
Areas that maybe impacted
https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=1336-34320&mode=dev
Steps to test
jump to
jump to
jump to
screen will appear two cards containing the fixed styles.status: ready